Laszlo Hornyak has posted comments on this change.
Change subject: engine: move static method
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsCpuVdsLoadBalancingAlgorithm.java
Line 34: @Override
Line 35: public boolean eval(VDS p) {
Line 36: return p.getUsageCpuPercent() >= p.getHighUtilization()
Line 37: && p.getCpuOverCommitTimestamp() != null
Line 38: && (new Date().getTime() -
p.getCpuOverCommitTimestamp().getTime()) >= p
looks like a minor unrelated change
Line 39: .getCpuOverCommitDurationMinutes() *
1000L * 60L;
Line 40: }
Line 41: });
Line 42:
--
To view, visit http://gerrit.ovirt.org/16106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I447eec70ecb06daf4e8208f49e4478e4786b1cd0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
