Laszlo Hornyak has posted comments on this change.

Change subject: engine: add comment field to Cluster [2]
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 33: 
Line 34:     @Size(max = BusinessEntitiesDefinitions.GENERAL_MAX_SIZE)
Line 35:     private String description;
Line 36: 
Line 37:     private String comment;
ok, so changing back everything to varchar(4000) and adding size validation
Line 38: 
Line 39:     @Size(max = BusinessEntitiesDefinitions.CLUSTER_CPU_NAME_SIZE)
Line 40:     private String cpu_name;
Line 41: 


-- 
To view, visit http://gerrit.ovirt.org/15414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b203b757d6225ff1986aee47e8484e2838e795
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to