Tal Nisan has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
Line 613: protected NetworkDao getNetworkDAO() {
Line 614: return getDbFacade().getNetworkDao();
Line 615: }
Line 616:
Line 617: public AsyncTaskDAO getAsyncTaskDao() {
Yes, because I needed to mock it and the test doesn't extend the command, most
of the getXXXDao methods were changed to public anyway
Line 618: return getDbFacade().getAsyncTaskDao();
Line 619: }
Line 620:
Line 621: protected DbFacade getDbFacade() {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 703: // deal with the case that there are several hosts with
the same priority.
Line 704: List<VDS> allVds =
DbFacade.getInstance().getVdsDao().getListForSpmSelection(_storagePoolId);
Line 705: List<VDS> vdsRelevantForSpmSelection = new
ArrayList<VDS>();
Line 706: Guid preferredHost =
getIrsProxyData(_storagePoolId).getPreferredHost();
Line 707: getIrsProxyData(_storagePoolId).setPreferredHost(null);
Because otherwise it might persist to the next change of SPM and set it on the
top of the list, this should only be done once
Line 708:
Line 709: for (VDS vds : allVds) {
Line 710: if (!mTriedVdssList.contains(vds.getId()) &&
!vds.getId().equals(curVdsId)) {
Line 711: if (vds.getId().equals(preferredHost)) {
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 183:
Line 184: @DefaultStringValue("Cannot ${action} ${type}. Internal Error:
Host does not exists in DB.")
Line 185: String VDS_NOT_EXIST();
Line 186:
Line 187: @DefaultStringValue("Cannot ${action} ${type}. The Host
${VdsName} is not active.")
We had this discussion before, the PMs want the system entities to start with a
capital letter, this is the convention used in the rest of the messages also
Line 188: String CANNOT_REINIT_SPM_VDS_NOT_UP();
Line 189:
Line 190: @DefaultStringValue("Cannot ${action} ${type}. The Host
${VdsName} is already SPM or contending.")
Line 191: String CANNOT_REINIT_SPM_VDS_ALREADY_SPM();
Line 192:
Line 193: @DefaultStringValue("Cannot ${action} ${type}. The SPM priority
of Host ${VdsName} is set to never. This Host cannot be elected as SPM.")
Line 194: String CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM();
Line 195:
Line 196: @DefaultStringValue("Cannot ${action} ${type}. The Storage Pool
has running tasks.")
Cancel tasks is not really an option, having to wait is not implicit? I mean,
this is an admin console
Line 197: String CANNOT_REINIT_SPM_STORAGE_POOL_HAS_RUNNING_TASKS();
Line 198:
Line 199: @DefaultStringValue("Internal error: Host protocol error.")
Line 200: String VDS_PROTOCOL_ERROR();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 136: }
Line 137:
Line 138: private UICommand setAsSpmCommand;
Line 139:
Line 140: public UICommand getSetAsSpmCommand()
Hehe yes indeed, I wanted to keep to the convention but it's not a must, do you
have a suggestion?
Line 141: {
Line 142: return setAsSpmCommand;
Line 143: }
Line 144:
--
To view, visit http://gerrit.ovirt.org/16105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab31fc7918b10448b923821547a583f3d6c3fcba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
