Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: added upgrade from legacy plugin ......................................................................
Patch Set 8: (1 inline comment) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 124: LEGACY_OVIRT_ENGINE_SYSCONFIG = os.path.join( Line 125: SYSCONFDIR, Line 126: 'sysconfig', Line 127: 'ovirt-engine', Line 128: ) I can't see any access to FILE_ENGINE_SYSCONFIG in engine-upgrade.py on 3.2 branch. So it seems it's not resolved in oVirt 3.2.z Line 129: Line 130: LEGACY_PSQL_PASS_FILE = os.path.join( Line 131: OVIRT_ENGINE_SYSCONFDIR, Line 132: '.pgpass', -- To view, visit http://gerrit.ovirt.org/15975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ee25f561218d83c5a4bd821c2d89587df5bc47a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
