Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fixed validation when moving host to gluster cluster
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 96:
Line 97: private boolean hasUpServer(VDSGroup cluster, boolean
isTargetCluster) {
Line 98: // if target cluster, need to check if cluster has other
servers
Line 99: // otherwise, cluster should have multiple servers
Line 100: int serverCount = isTargetCluster? 0:1;
looks like boolean tricks to me (reminds me of how boolean is implemented in C).
I would prefer introducing a new method to getClusterUtils().hasServers(Guid
clusterId).
Line 101:
Line 102: if (getClusterUtils().getServerCount(cluster.getId()) >
serverCount
Line 103: && getClusterUtils().getUpServer(cluster.getId()) ==
null) {
Line 104: addCanDoActionMessage(String.format("$clusterName %1$s",
cluster.getname()));
--
To view, visit http://gerrit.ovirt.org/16027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2f2fbbc5da529932da967fc67ea8b7e34459fbd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
