Yair Zaslavsky has posted comments on this change.
Change subject: core: RFE-Adding External Tasks Support
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1712: *
Line 1713: * @return A map which contains the data to be used to populate
the {@code Job} description.
Line 1714: */
Line 1715: public Map<String, String> getJobMessageProperties() {
Line 1716: jobProperties = new HashMap<String, String>();
Not that critical but in general you can use now a syntax of JDK7 - new
HashMap<>
Line 1717: List<PermissionSubject> subjects =
getPermissionCheckSubjects();
Line 1718: if (jobProperties == null && subjects != null) {
Line 1719: if (!subjects.isEmpty()) {
Line 1720: VdcObjectType entityType;
Line 1714: */
Line 1715: public Map<String, String> getJobMessageProperties() {
Line 1716: jobProperties = new HashMap<String, String>();
Line 1717: List<PermissionSubject> subjects =
getPermissionCheckSubjects();
Line 1718: if (jobProperties == null && subjects != null) {
IMHO we can reduce one level of if nesting - i dont see an "else" part to if
(!subject.isEmpty) so we can put it as 3rd clause in the above if.
Line 1719: if (!subjects.isEmpty()) {
Line 1720: VdcObjectType entityType;
Line 1721: Guid entityId;
Line 1722: String value;
--
To view, visit http://gerrit.ovirt.org/15219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I622e2a92b0433edbbf45fc4ed4f352cb2d09872d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
