Yair Zaslavsky has posted comments on this change.
Change subject: core: DB, DAO and related BE patch for external..
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
Line 305: result = prime * result + ((ownerId == null) ? 0 :
ownerId.hashCode());
Line 306: result = prime * result + ((startTime == null) ? 0 :
startTime.hashCode());
Line 307: result = prime * result + ((status == null) ? 0 :
status.hashCode());
Line 308: result = prime * result + ((steps == null) ? 0 :
steps.hashCode());
Line 309: result = prime * result + (external ? 1231 : 1237);
Should autoCleared be a part of hashCode calculation?
Line 310: return result;
Line 311: }
Line 312:
Line 313: @Override
Line 386: }
Line 387: } else if (!steps.equals(other.steps)) {
Line 388: return false;
Line 389: }
Line 390: if (external != other.external) {
Should autoCleared be a part of equals?
Line 391: return false;
Line 392: }
Line 393:
Line 394: return true;
--
To view, visit http://gerrit.ovirt.org/15221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04a2d92fecd43d218f82e39c3a85f27cd3fad1e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
