Yair Zaslavsky has posted comments on this change.
Change subject: core: Enable to inject a job in Execution..
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 208: private static Job getJob(CommandBase<?> command, VdcActionType
actionType) {
Line 209: VdcActionParametersBase params = command.getParameters();
Line 210: Job job;
Line 211: // if Job is external, we had already created the Job by
AddExternalJobCommand, so just get it from DB
Line 212: if (params.getJobId() != null) {
Regarding our previous round of discussion -
I don't mind having a boolean helper method on pamraeters boolean
hasExternalTask() -
make sure to annotate it with @JsonIgnore
Line 213: job =
DbFacade.getInstance().getJobDao().get((Guid)params.getJobId());
Line 214: }
Line 215: else {
Line 216: job = createJob(actionType, command);
--
To view, visit http://gerrit.ovirt.org/15224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e2fb56663ca730b3fb98ad53e653d3584857540
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
