Alon Bar-Lev has posted comments on this change.
Change subject: Adding initialize function in vdsDeploy
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java
Line 23: * Get host fingerprint.
Line 24: * @return fingerprint.
Line 25: */
Line 26: public String getHostFingerprint() throws IOException {
Line 27: if (_client == null) {
I prefer a simple exception... java.net.ConnectException with "SSH is not
connected".
Line 28: throw new IOException("failed to get host fingerprint. " +
Line 29: "SSH connection was not initialized");
Line 30: }
Line 31: return ((EngineSSHClient)_client).getHostFingerprint();
....................................................
Commit Message
Line 3: AuthorDate: 2013-06-27 15:16:32 +0300
Line 4: Commit: Yaniv Bronhaim <[email protected]>
Line 5: CommitDate: 2013-06-27 15:45:29 +0300
Line 6:
Line 7: Adding initialize function in vdsDeploy
please fix message.
Line 8:
Line 9: Currently the creation of the client is part of vdsDeploy.execute.
Line 10: We want to allow setting defaultKeyPair before executing the deploy
code.
Line 11: This patch separates the initialization of SSHDialog and the execution.
--
To view, visit http://gerrit.ovirt.org/16184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02edaee6bc6e804bb36d3ab4dabaa21faa926fa0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
