Omer Frenkel has posted comments on this change.
Change subject: engine: migration initiation reason is missing from event logs
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java
Line 59: Config.<Integer>
GetValue(ConfigValues.UtilizationThresholdInPercent));
Line 60: AuditLogableBase logable = new AuditLogableBase();
Line 61: logable.addCustomValue("ClusterName", group.getname());
Line 62: logable.addCustomValue("Algorithm",
group.getselection_algorithm().toString());
Line 63: AuditLogDirector.log(logable,
AuditLogType.VM_MIGRATION_CLUSTER_ALGORITHM_START);
i dont think this logging is a good solution,
this will be logged every minute which will cause flood in event log.
since the bug mentioned in the commit message is pretty old, i think we need to
check first if currently there is a proper log when migration started by the
scheduler (per vm) and if not, fix it
Line 64:
migrationHandler.migrateVMs(loadBalancingAlgorithm.LoadBalance());
Line 65: } else {
Line 66: log.debugFormat("VdsLoadBalancer: Cluster {0} skipped
because no selection algorithm selected.",
Line 67: group.getname());
--
To view, visit http://gerrit.ovirt.org/16099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I822526580c5385d68d9bef67363bc1ab48768694
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
