Omer Frenkel has posted comments on this change.
Change subject: core: organize can-do methods
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 440: protected boolean canAddVm(List<String> reasons, String name,
Guid storagePoolId,
Line 441: int vmPriority) {
Line 442: // Checking if a desktop with same name already exists
Line 443: if (isVmWithSameNameExists(name)) {
Line 444: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
need to add error to reasons list as well
Line 445: }
Line 446:
Line 447: if (!verifyAddVM(reasons, vmPriority)) {
Line 448: return false;
--
To view, visit http://gerrit.ovirt.org/15959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4589fa4681913e41b1be595131686932d92ca062
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
