Doron Fediuck has posted comments on this change.
Change subject: engine: handle null values in EngineEncryptionUtils
......................................................................
Patch Set 2: I would prefer that you didn't submit this
Actually this may be a dangerous behavior change;
Take a look at DBConfigUtils.java:
case Password:
try {
result = EngineEncryptionUtils.decrypt((String) result);
Now all the java code will get NULL instead of "" it got so far, which is an
awesome way to hit NPE in runtime.
I really prefer this is properly verified assuming this is the right behavior.
Alternatively, the offending test may be skipped or changed accordingly.
--
To view, visit http://gerrit.ovirt.org/16180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2d736ea71c8af1ac9facffd4b2b005edb5da70c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
