Allon Mureinik has posted comments on this change.
Change subject: core: organize RemoveDiskCommand#canRemoveTemplateDisk
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
Minor stylin' suggestion, not critical.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 199:
Line 200: private List<String> getNamesOfDerivedVmsFromTemplate(DiskImage
diskImage) {
Line 201: List<String> result = new ArrayList<String>();
Line 202: for (VM vm :
getDbFacade().getVmDao().getAllWithTemplate(getVmTemplateId())) {
Line 203: for (Disk vmDisk :
getDbFacade().getDiskDao().getAllForVm(vm.getId())) {
just use getDiskDao(), getVmDao(), etc.
Line 204: if (vmDisk.getDiskStorageType() ==
DiskStorageType.IMAGE) {
Line 205: DiskImage vmDiskImage = (DiskImage) vmDisk;
Line 206: if
(vmDiskImage.getImageTemplateId().equals(diskImage.getImageId())) {
Line 207: if
(vmDiskImage.getStorageIds().contains(getParameters().getStorageDomainId())) {
--
To view, visit http://gerrit.ovirt.org/15876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ddc1e6abd85c61ac1486cdd60744124ebfb27b9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
