Lior Vernia has uploaded a new change for review. Change subject: webadmin: Sorting Providers in AsyncDataProvider ......................................................................
webadmin: Sorting Providers in AsyncDataProvider Noticed that providers weren't sorted in the System Tree, so AsyncDataProvider seemed like it's as good a place as any to perform the sorting, as likely all its users would need the items to be sorted. This made redundant the sorting elsewhere. Also changed SystemTreeModel to use the AsyncDataProvider method. Change-Id: I6925aab1d5231256124f4ef045bd7a20bd9c8e20 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/16250/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java index feddf65..543c962 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java @@ -2626,6 +2626,7 @@ { return new ArrayList<Provider>(); } + Collections.sort((List<Provider>) source, new Linq.ProviderComparator()); return source; } }; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java index 1692c61..51f4150 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java @@ -14,7 +14,6 @@ import org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeEntity; import org.ovirt.engine.core.common.businessentities.network.Network; import org.ovirt.engine.core.common.mode.ApplicationMode; -import org.ovirt.engine.core.common.queries.GetAllProvidersParameters; import org.ovirt.engine.core.common.queries.IdQueryParameters; import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; import org.ovirt.engine.core.common.queries.VdcQueryReturnValue; @@ -352,11 +351,11 @@ @SuppressWarnings("unchecked") @Override public void onSuccess(Object model, Object returnValue) { - setProviders((List<Provider>) ((VdcQueryReturnValue) returnValue).getReturnValue()); + setProviders((List<Provider>) returnValue); AsyncDataProvider.getDataCenterList(dcQuery); } }; - Frontend.RunQuery(VdcQueryType.GetAllProviders, new GetAllProvidersParameters(), providersQuery); + AsyncDataProvider.GetAllProviders(providersQuery); } @Override -- To view, visit http://gerrit.ovirt.org/16250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6925aab1d5231256124f4ef045bd7a20bd9c8e20 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
