Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: log setup events - add otopi upgrade ......................................................................
Patch Set 1: (2 inline comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 538: Line 539: ACTION_SETUP = 'setup' Line 540: ACTION_REMOVE = 'cleanup' Line 541: ACTION_UPGRADE_FROM_LEGACY = 'upgrade (from monolithic setup)' Line 542: ACTION_UPGRADE_FROM_OTOPI = 'upgrade (from otopi setup)' We already have sandro patch[1] to add a mark if we upgrade from legacy or not. We do not need another environment for that, the fact that the value of these is string is incorrect, it should be plain enum, having 'setup' and 'cleanup' was OK, now you start add human texts which is invalid. Human text should be a translation of the constants at the designated plugin. [1] http://gerrit.ovirt.org/#/c/15975/ Line 543: Line 544: Line 545: @util.export Line 546: @util.codegen .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/misc.py Line 64: osetupcons.FileLocations.OVIRT_SETUP_POST_INSTALL_CONFIG Line 65: ): Line 66: self.environment[ Line 67: osetupcons.CoreEnv.ACTION Line 68: ] = osetupcons.Const.ACTION_UPGRADE_FROM_OTOPI we will not have engine-upgrade script, upgrade will be done when running setup on already setuped machine. Line 69: else: Line 70: self.environment[ Line 71: osetupcons.CoreEnv.ACTION Line 72: ] = osetupcons.Const.ACTION_SETUP -- To view, visit http://gerrit.ovirt.org/16245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0805134c602f37a646065a8794feb3721587d601 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
