Arik Hadas has posted comments on this change. Change subject: core: rename getSucceeded method to isSucceeded in VDSReturnValue ......................................................................
Patch Set 3: since according to java convention getters for boolean fields can start with prefix 'get' as well (even though it is more common to use prefix 'is') and such change will cause rebases to be harder, it is not something that needs to be fixed quickly. I didn't want to stall merging of patch 15960, so I decided to abandon this one for now. -- To view, visit http://gerrit.ovirt.org/15874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I060afe92b6dcfcafac4128795cdea84f3a8659da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
