Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds config of SSH Soft Fencing command
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 91: SupportCustomDeviceProperties(ConfigAuthType.User),
Line 92: CustomDeviceProperties(ConfigAuthType.User),
Line 93: MultipleGatewaysSupported,
Line 94: VirtIoScsiEnabled(ConfigAuthType.User),
Line 95: SshSoftFencingCommand
I also asked this question when I reviewed with Martin.
Are we 100% sure we do not want to let the admin change the command the
defaults?
Line 96: ;
Line 97:
Line 98: public static enum ConfigAuthType {
Line 99: Admin,
--
To view, visit http://gerrit.ovirt.org/15797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f96cbe0c5fdc33f8f512c36d1cd85349852f2da
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
