Ori Liel has posted comments on this change.

Change subject: [WIP] API: Adding Step mapping class
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StepMapperTest.java
Line 13:     @Override
Line 14:     protected void verify(Step model, Step transform) {
Line 15:         assertNotNull(transform);
Line 16:         assertEquals(model.getId(), transform.getId());
Line 17:         assertEquals(model.getDescription(), 
transform.getDescription());
Maybe better to test some more fields
Line 18:     }
Line 19: 
Line 20:     @Override
Line 21:     protected Step postPopulate(Step model) {


-- 
To view, visit http://gerrit.ovirt.org/16161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91603274
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to