Allon Mureinik has uploaded a new change for review. Change subject: core: Remove null check from Guid.equals(Object) ......................................................................
core: Remove null check from Guid.equals(Object) Since (null instanceof anyObject) always returns false anyway, it's redundant to explicitly check for nulls. Change-Id: Ia8a5a0ba443a7a0d1c8769ff73a723fb3be0f801 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/16279/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java index 024fc23..179b1d6 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java @@ -79,7 +79,7 @@ @Override public boolean equals(Object other) { - if (other == null || !(other instanceof Guid)) { + if (!(other instanceof Guid)) { return false; } Guid otherGuid = (Guid) other; -- To view, visit http://gerrit.ovirt.org/16279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8a5a0ba443a7a0d1c8769ff73a723fb3be0f801 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
