Allon Mureinik has uploaded a new change for review. Change subject: core: Move Guid constants ......................................................................
core: Move Guid constants Moved the constant Guid instances to be initialized after Guid's static fields to ensure that these Guids aren't partly initialized. This patch addresses the FindBugs wanring SI_INSTANCE_BEFORE_FINALS_ASSIGNED - "Static initializer for org.ovirt.engine.core.compat.Guid creates instance before all static final fields assigned" Change-Id: If239587d8bddba89e19253ec1e147ef770b60e85 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/16278/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java index 255fdb2..024fc23 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java @@ -9,15 +9,15 @@ */ private static final long serialVersionUID = 27305745737022810L; - public static final Guid SYSTEM = new Guid("AAA00000-0000-0000-0000-123456789AAA"); - public static final Guid EVERYONE = new Guid("EEE00000-0000-0000-0000-123456789EEE"); - public final static Guid Empty = new Guid("00000000-0000-0000-0000-000000000000"); - private static final byte[] CHANGE_BYTE_ORDER_INDICES = { 3, 2, 1, 0, 5, 4, 7, 6, 8, 9, 10, 11, 12, 13, 14, 15 }; private static final byte[] KEEP_BYTE_ORDER_INDICES = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 }; + public static final Guid SYSTEM = new Guid("AAA00000-0000-0000-0000-123456789AAA"); + public static final Guid EVERYONE = new Guid("EEE00000-0000-0000-0000-123456789EEE"); + public static final Guid Empty = new Guid("00000000-0000-0000-0000-000000000000"); + private UUID uuid; /** -- To view, visit http://gerrit.ovirt.org/16278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If239587d8bddba89e19253ec1e147ef770b60e85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
