Mike Kolesnik has posted comments on this change.
Change subject: core: Exaple: Use UUID for handling database Guids
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java
Line 141: * @param columnName the name of the column.
Line 142: * @return a {@link Guid} representing the UUID in the column, or
the default value if it was <code>null</code>.
Line 143: * @throws SQLException If resultSet does not contain columnName
or its value cannot be cast to {@link UUID}.
Line 144: */
Line 145: protected static Guid getGuidDefaultNull(ResultSet resultSet,
String columnName) throws SQLException {
I don't think 'DefaultEmpty' is necessary in this column name.
It is by contract that each java method can return an instance, or null, so
specifying it explicitly is like specifying the parameters in the name, i.e.
getGuidFromResultSetByColumnNameDefaultEmpty
It is also consistent with the 'Guid.createGuidFromString' method names
(Although there the 'FromString' part seems quite redundant).
Line 146: return getGuid(resultSet, columnName, null);
Line 147: }
Line 148:
Line 149: /**
--
To view, visit http://gerrit.ovirt.org/16281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d30e1ab7303ecad68dbc9005ac5c6ef733f1707
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
