Lior Vernia has posted comments on this change.

Change subject: webadmin: Added ListBox column to be used with CellTable
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxCell.java
Line 94: 
Line 95:                     @Override
Line 96:                     public void update(String value) {
Line 97:                         if (value != null) {
Line 98:                             
model.setSelectedItem(entityByName.get(value));
I'm not sure I understand well how cells work, but I think that's what I did in 
the render method? I think by delegating the rendering to the SelectionCell 
with a value that corresponds to the selected item, that's what's gonna be 
shown as selected.
Line 99:                         }
Line 100:                     }
Line 101:                 });
Line 102:     }


-- 
To view, visit http://gerrit.ovirt.org/16198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9c04c5c32e9a36fa959af55399a44ff33d175d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to