Martin Peřina has uploaded a new change for review. Change subject: core: SshSoftFencingCommand.executeCommand cleanup ......................................................................
core: SshSoftFencingCommand.executeCommand cleanup Adds result of command execution to the return value. Change-Id: I2b65fdde5ac3f2642fb053777ef50846cb8cb8e0 Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/16338/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java index ef0434f..2aa890b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java @@ -37,7 +37,7 @@ log.infoFormat("SSH Soft Fencing will not be executed on host {0}({1}) since it doesn't exist anymore.", getVdsName(), getVdsId()); - getReturnValue().setSucceeded(result); + getReturnValue().setSucceeded(false); return; } @@ -49,13 +49,14 @@ // SSH Soft Fencing executed without errors, tell VdsManager about it ResourceManager.getInstance().GetVdsManager(getVds().getId()).finishSshSoftFencingExecution(getVds()); } + getReturnValue().setSucceeded(result); } else { setCommandShouldBeLogged(false); log.infoFormat("SSH Soft Fencing will not be executed on host {0}({1}) since it's status is ok.", getVdsName(), getVdsId()); + getReturnValue().setSucceeded(false); } - getReturnValue().setSucceeded(result); } /** -- To view, visit http://gerrit.ovirt.org/16338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2b65fdde5ac3f2642fb053777ef50846cb8cb8e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
