Juan Hernandez has posted comments on this change.
Change subject: [WIP] Introduce new directory interface
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/directory/DirectoryEntry.java
Line 66: // Empty user name or a user with empty domain will be
returned as is:
Line 67: if (name == null || name.length() == 0 || name.contains("@")
|| directory == null) {
Line 68: return name;
Line 69: } else {
Line 70: return name + "@" + directory.getName();
I think this is valid for all directory entries, maybe the comments are too
"user" specific.
Currently this is what we store in the vm_dynamic table to indicate the name of
the current console user, which is then displayed in the "sessions" subtab of
the "VMs" main tab. In addition to displaying it we also use it to check that
is not empty, so any value will do.
Do you suggest to move it to the "DirectoryUser" class?
We can also remove this method completely and construct whatever we need when
updating the vm_dynamic table in the SetVmTicketCommand class (it is the only
place where we call this method).
Line 71: }
Line 72: }
Line 73:
Line 74: @Override
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/directory/DirectoryManager.java
Line 176: return null;
Line 177: }
Line 178:
Line 179: // Actually load the directory from the configuration:
Line 180: return loadInstance(file, configuration);
Do you mean renaming all the "loadInstance" methods to "parseInstance" or only
the methods that takes the Properties object parameter?
Line 181: }
Line 182:
Line 183: /**
Line 184: * Loads a directory service instance from a set of properties.
--
To view, visit http://gerrit.ovirt.org/15596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
