Alexander Wels has posted comments on this change.
Change subject: core: i18n welcome page with branding
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/branding/ovirt.brand/messages.properties
Line 46:
obrand.welcome.section1.row1.url=UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0}
Line 47: obrand.welcome.section1.row2.text=Administrator Portal
Line 48:
obrand.welcome.section1.row2.url=webadmin/webadmin/WebAdmin.html?locale={0}
Line 49: obrand.welcome.section1.row3.text=Reports Portal
Line 50:
obrand.welcome.section1.row3.url=OvirtEngineWeb/RedirectServlet?Page=Reports
All of this is dynamic, I think the issue you are having is the fact that I am
mixing messages and structure in the same properties file. I have the same
issue, but I couldn't think of a better way that I liked.
In reality we should have 2 files:
* The messages (just the messages)
* The structure (the sections/urls)
Unfortunately if we have 2 files we get a lot of duplication, because the
structure file has to reference the message keys so we know where to put
messages in the resulting output.
--
To view, visit http://gerrit.ovirt.org/16359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
