Allon Mureinik has uploaded a new change for review. Change subject: core: OpenstackNetworkProviderProperties#equals ......................................................................
core: OpenstackNetworkProviderProperties#equals OpenstackNetworkProviderProperties.equals(Object) was broken in patch Ib12a76a069d1d4b5c6cac642bfe6a3da1338a4c5 when pluginType was changed from OpenstackNetworkPluginType which can use "!=" since it's an enum to a String. This patch fixes the equals(Object) method by using !equals instead of !=. Change-Id: Idac272b69c9460a9d56192fc9ddc1ae81de3a331 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/16428/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java index c0a7067..93fa55b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java @@ -34,7 +34,7 @@ return false; } OpenstackNetworkProviderProperties other = (OpenstackNetworkProviderProperties) obj; - if (getPluginType() != other.getPluginType()) { + if (!getPluginType().equals(other.getPluginType())) { return false; } return true; -- To view, visit http://gerrit.ovirt.org/16428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idac272b69c9460a9d56192fc9ddc1ae81de3a331 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
