Allon Mureinik has uploaded a new change for review. Change subject: core: Guid.ToByteArray -> Guid.toByteArray ......................................................................
core: Guid.ToByteArray -> Guid.toByteArray As per Java coding conventions. Change-Id: I2457ba75fbe8c427b143b8b9d1bb9dac3c3c3053 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/16436/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java index 9cc584e..91a0586 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java @@ -16,7 +16,7 @@ @Override public String encodeGuid(Guid guid) { - byte[] ba = GuidUtils.ToByteArray(guid.getUuid()); + byte[] ba = GuidUtils.toByteArray(guid.getUuid()); // AD guid is stored in reversed order than MS-SQL guid - // Since it is important for us to work with GUIDs which are MS-SQL @@ -24,7 +24,7 @@ // for each GUID -before using with AD we will change its byte order to // support AD Guid adGuid = new Guid(ba, false); - ba = GuidUtils.ToByteArray(adGuid.getUuid()); + ba = GuidUtils.toByteArray(adGuid.getUuid()); StringBuilder sb = new StringBuilder(); for (int idx = 0; idx < ba.length; idx++) { sb.append("\\" + String.format("%02X", ba[idx])); diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java index 9617057..ff9f5c8 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java @@ -11,7 +11,7 @@ public class GuidUtils { - public static byte[] ToByteArray(UUID uuid) { + public static byte[] toByteArray(UUID uuid) { String guidStr = uuid.toString(); // Going to split the GUID to hexadecimal sequences. diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java index d38091a..3750364 100644 --- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java +++ b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java @@ -13,14 +13,14 @@ public class GuidUtilsTest { @Test public void toByteArray() { - final byte[] byteArray = GuidUtils.ToByteArray(UUID.randomUUID()); + final byte[] byteArray = GuidUtils.toByteArray(UUID.randomUUID()); Assert.assertNotNull(byteArray); Assert.assertEquals(16, byteArray.length); } @Test public void toByteArrayAllNoll() { - final byte[] allNullArray = GuidUtils.ToByteArray(UUID.fromString("00000000-0000-0000-0000-000000000000")); + final byte[] allNullArray = GuidUtils.toByteArray(UUID.fromString("00000000-0000-0000-0000-000000000000")); Assert.assertNotNull(allNullArray); for (int i = 0; i < 16; i++) { Assert.assertEquals(0, allNullArray[i]); -- To view, visit http://gerrit.ovirt.org/16436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2457ba75fbe8c427b143b8b9d1bb9dac3c3c3053 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
