Martin Sivák has posted comments on this change. Change subject: Reorganize the Monitor classes ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File mom/Monitor.py Line 55: Line 56: self.ready = None Line 57: self._terminate = False Line 58: self.fields = None Line 59: self.update_collectors() I generally do not like too active constructors. Wouldn't it be better if the consistency check was performed when the Monitor is about to be started instead of at the creation time? That way we might be able to prepare the class dynamically in the future for example without killing the whole thing just because we are not finished with the setup yet.. serialization comes into my mind. Line 60: Line 61: def run(self): Line 62: if not self._should_run(): Line 63: return -- To view, visit http://gerrit.ovirt.org/13763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c8121e1dfccb4a5f4ed30ded670c2df8d42a043 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Mei Liu <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
