Tal Nisan has posted comments on this change. Change subject: core: Fix VDS.hashCode() ......................................................................
Patch Set 1: Looks good to me, approved I don't see any reason why not, this fits the Java standards + both fields are very dynamic which can causes 2 VDS objects of the same entity that was fetched from the db 30 seconds one after another to be equal yet with a different hashcode and it can cause some problems with hashed collections -- To view, visit http://gerrit.ovirt.org/16432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie006b12f59762bc92663007a37bf46325f8f9378 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
