Laszlo Hornyak has posted comments on this change.
Change subject: core: GuidUtils patterns
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
Line 12:
Line 13: public class GuidUtils {
Line 14:
Line 15: private static final Pattern GUID_PART_PATTERN =
Pattern.compile("-");
Line 16: private static final Pattern GUID_LIST_PATTERN =
Pattern.compile(",");
I measured actually slower processing with the Pattern in case the regexp is
only one character. I posted the results here:
http://dummywarhead.blogspot.com/2013/07/stringsplit-versus-patternsplit.html
but even then: thank you for this patch, it is very interesting.
Line 17:
Line 18: public static byte[] toByteArray(UUID uuid) {
Line 19: String guidStr = uuid.toString();
Line 20:
--
To view, visit http://gerrit.ovirt.org/16437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1935c8e6e0c150a6bc7fdc7dc7428b95cb1fce59
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
