Alissa Bonas has posted comments on this change.

Change subject: core: disaster recovery on update connection [wip]
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 205:                 }
Line 206: 
Line 207:                 for (LUNs lunFromVgInfo : lunsFromVgInfo) {
Line 208:                     for (LUNs lunFromDb : lunsFromDb) {
Line 209:                         if (lunFromDb.getphysical_volume_id() == null 
||
Adding a new lun/removing an old lun - this should be done based on user input, 
not automatically in the background, right?
Line 210:                                 
!lunFromDb.getphysical_volume_id().equals(lunFromVgInfo.getphysical_volume_id()))
 {
Line 211:                             continue;
Line 212:                         }
Line 213: 


-- 
To view, visit http://gerrit.ovirt.org/16533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0be9c598ee666df2977ffbc2526e2d3fbd997e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to