Arik Hadas has posted comments on this change.
Change subject: core: snapshot's memory volume type by storage type
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 378: *
Line 379: * @return - VolumeType of allocation type to use.
Line 380: */
Line 381: public static VolumeType getMemoryVolumeTypeForPool(StorageType
storageType) {
Line 382: return storageType.isFileDomain() ? VolumeType.Sparse :
VolumeType.Preallocated;
I agree. it is temporary.. a follow-up patch (for the ram snapshot's patches)
will move it into the LiveSnapshotMemoryImageBuilder class (which should be
renamed to something more general) as private method and HibernateVmCommand
will use this class to create its images
Line 383: }
Line 384:
Line 385: private static Log log =
LogFactory.getLog(HibernateVmCommand.class);
--
To view, visit http://gerrit.ovirt.org/16529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c0031c4257576d16162ef09bb5086b5ee784132
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
