Daniel Erez has posted comments on this change.
Change subject: engine: add comment field to Cluster [2]
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
Line 86: };
Line 87: getTable().addColumn(cpuNameColumn,
constants.cpuNameCluster(), "150px"); //$NON-NLS-1$
Line 88: }
Line 89:
Line 90: getTable().addColumn(new CommentColumn<VDSGroup>(),
constants.commentLabel());
width value is mandatory (for resizable columns support)
Line 91:
Line 92: getTable().addActionButton(new
WebAdminButtonDefinition<VDSGroup>(constants.newCluster()) {
Line 93: @Override
Line 94: protected UICommand resolveCommand() {
--
To view, visit http://gerrit.ovirt.org/15414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b203b757d6225ff1986aee47e8484e2838e795
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
