Daniel Erez has posted comments on this change.
Change subject: engine: add comment field to Host [3]
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
Line 194: };
Line 195: getTable().addColumn(spmColumn,
constants.spmPriorityHost(), "100px"); //$NON-NLS-1$
Line 196: }
Line 197:
Line 198: getTable().addColumn(new CommentColumn<VDS>(),
constants.commentLabel());
width value is mandatory (for resizable columns support)
Line 199:
Line 200: getTable().addActionButton(new
WebAdminButtonDefinition<VDS>(constants.newHost()) {
Line 201: @Override
Line 202: protected UICommand resolveCommand() {
--
To view, visit http://gerrit.ovirt.org/15421
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06e1bec7c4a862813b19073344f48a0ec3c17458
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
