Daniel Erez has posted comments on this change.
Change subject: engine: add comment field to Network [4]
......................................................................
Patch Set 11: Looks good to me, but someone else must approve
(1 inline comment)
please verify later on that the column's width is identical on every main tab.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
Line 90: }
Line 91: };
Line 92: getTable().addColumn(descriptionColumn,
constants.descriptionNetwork(), "300px"); //$NON-NLS-1$
Line 93:
Line 94: getTable().addColumn(new CommentColumn<NetworkView>(),
constants.commentLabel(), "100px"); //$NON-NLS-1$
please verify later on that the column's width is identical on every main tab.
Line 95:
Line 96: SafeHtmlWithSafeHtmlTooltipColumn<NetworkView> roleColumn =
Line 97: new SafeHtmlWithSafeHtmlTooltipColumn<NetworkView>() {
Line 98: @Override
--
To view, visit http://gerrit.ovirt.org/15484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935df2acf56afe5fd09249aead7ff6827e360216
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
