Daniel Erez has posted comments on this change.
Change subject: [wip] frontend: add glance storage domain support
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
Line 20: }
Line 21:
Line 22: @Override
Line 23: public String render(T size) {
Line 24: if (size == null || size.longValue() == 0) {
I guess we should make the change specifically for glance?
I.e. it should remain '< 1 GB' for 'regular' disks.
Line 25: return "NA"; //$NON-NLS-1$
Line 26: }
Line 27:
Line 28: long sizeInGB = -1;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
Line 195:
Line 196: @Source("images/torn_chain.png")
Line 197: ImageResource tornChainImage();
Line 198:
Line 199: @Source("images/glance_icon.png")
did Eldan have a look on the icon? (dimensions/etc...)
Line 200: ImageResource glanceIconImage();
Line 201:
Line 202: @Source("images/unconfigured.png")
Line 203: ImageResource unconfiguredImage();
--
To view, visit http://gerrit.ovirt.org/15898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07274bbc14e52471242935fcf99b510469ec4abe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
