Kanagaraj M has posted comments on this change.
Change subject: gluster: Correct SWIFT status if no hosts in cluster
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java
Line 57: if (supportsGlusterServicesFeature(cluster)) {
Line 58: try {
Line 59: List<VDS> serversList =
getClusterUtils().getAllServers(cluster.getId());
Line 60: // If there are no servers in the cluster, set the
status as unknown
Line 61: if(serversList != null && serversList.size() == 0)
{
please use serversList.isEmpty()
Line 62: Map<ServiceType, GlusterServiceStatus>
statusMap = new HashMap<>();
Line 63: for(ServiceType type :
getClusterServiceMap(cluster).keySet()) {
Line 64: statusMap.put(type,
GlusterServiceStatus.UNKNOWN);
Line 65: }
Line 64: statusMap.put(type,
GlusterServiceStatus.UNKNOWN);
Line 65: }
Line 66: addOrUpdateClusterServices(cluster, statusMap);
Line 67: continue;
Line 68: }
below lines can be moved to else block
Line 69: List<Callable<Map<String, GlusterServiceStatus>>>
taskList = createTaskList(serversList);
Line 70: if (taskList != null && taskList.size() > 0) {
Line 71: refreshClusterServices(cluster,
ThreadPoolUtil.invokeAll(taskList));
Line 72: }
--
To view, visit http://gerrit.ovirt.org/16573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17080ac2d3eb5ec87b2efcc86bdca750995bce0e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
