Doron Fediuck has posted comments on this change. Change subject: tools:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal ......................................................................
Patch Set 1: (2 inline comments) Hi guys, see inline. Additionally, I'm missing a fix for editing a template which has the exact same issue. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java Line 184: USER_RUN_UNLOCK_ENTITY_SCRIPT(2024), Line 185: USER_MOVE_IMAGE_GROUP_FAILED_TO_DELETE_SRC_IMAGE(2025), Line 186: USER_MOVE_IMAGE_GROUP_FAILED_TO_DELETE_DST_IMAGE(2026), Line 187: USER_UPDATE_VM_FROM_TRUSTED_TO_UNTRUSTED(2031), Line 188: USER_UPDATE_VM_FROM_UNTRUSTED_TO_TRUSTED(2032), I suggest to move these to line 755 where we already have a TCP related event. Line 189: Line 190: // Quota audit logs Line 191: USER_ADD_QUOTA(3000), Line 192: USER_FAILED_ADD_QUOTA(3001), .................................................... Commit Message Line 3: AuthorDate: 2013-07-09 14:36:10 +0800 Line 4: Commit: Gang Wei <[email protected]> Line 5: CommitDate: 2013-07-09 14:36:10 +0800 Line 6: Line 7: tools:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal Updating a VM is not tools. Probably engine. Also, this isw no longer a proposal since the TCP was merged. Line 8: Line 9: Detailed description: http://wiki.ovirt.org/Trusted_compute_pools Line 10: Line 11: Edit a vm from a trusted/untrusted one to a untrusted/trusted one, then make an audit event. -- To view, visit http://gerrit.ovirt.org/16595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I477f0c76a011473ed0802b8e4a23738e34e52e18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gang Wei <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Emily Zhang <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
