Juan Hernandez has posted comments on this change. Change subject: core: [logging] Add the host name to the logging context ......................................................................
Patch Set 2: (1 inline comment) I have no objection to use the MDC concept, but I think we should use the log4j (or slf4j) implementation, not the JBoss specific one. I also agree that "host" is better than "vds", assuming that we want to move out of the "v..." family of names. .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java Line 10: import java.util.concurrent.atomic.AtomicInteger; Line 11: Line 12: import org.apache.commons.httpclient.HttpClient; Line 13: import org.apache.commons.lang.exception.ExceptionUtils; Line 14: import org.jboss.logging.MDC; Are you sure you want to use the org.jboss version of MDC? Doesn't the log4j MDC give the same result? If the log4j version works I would use it instead, as it makes the engine a bit less jboss dependent. If in the end you decide to use the org.jboss version then you should also add the corresponding dependency to the POM of the vdsbroker project (same if you use the log4j version, as we currently don't have any logging dependency in vdsbroker, as we use org.ovirt.engine.core.utils.log). I would suggest to use log4j or slf4j (I prefer slf4j) instead of org.ovirt.engine.core.utils.log and then use the corresponding MDC, but that is outside of the scope of this patch. Line 15: import org.ovirt.engine.core.common.AuditLogType; Line 16: import org.ovirt.engine.core.common.FeatureSupported; Line 17: import org.ovirt.engine.core.common.businessentities.NonOperationalReason; Line 18: import org.ovirt.engine.core.common.businessentities.VDS; -- To view, visit http://gerrit.ovirt.org/16548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafad27da56400741974132c956f90ba937c20a98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
