Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added HorizontalSplitTable widget
......................................................................
Patch Set 9: Verified; Looks good to me, approved
(1 inline comment)
I"ll merge this patch. Please fix my comment in a separate patch.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
Line 69: addClickHandler(upButton);
Line 70: }
Line 71:
Line 72: private void addSelectionHandler(final Button button) {
Line 73: final MultiSelectionModel<EntityModel> selectionModel =
Why don't you use getSelectionModelForButton?
Line 74: (button == downButton) ? topSelectionModel :
bottomSelectionModel;
Line 75: selectionModel.addSelectionChangeHandler(new Handler() {
Line 76:
Line 77: @Override
--
To view, visit http://gerrit.ovirt.org/16033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47b79ed09b69980ef763fecade0940bab0d517ec
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
