Barak Azulay has posted comments on this change.

Change subject: vdsm: packages: also start sgconfig if available
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/plugins/ovirt-host-deploy/vdsm/packages.py
Line 116:                 self.services.startup('libvirtd', True)
Line 117:             if self.services.exists('messagebus'):
Line 118:                 self.services.startup('messagebus', True)
Line 119:             if self.services.exists('sgconfig'):
Line 120:                 self.services.startup('sgconfig', True)
I think the service name should be cgconfig and not sgconfig
Line 121: 
Line 122:     # WORKAROUND-BEGIN
Line 123:     # old vdsm does not support the reconfigure trigger.
Line 124:     # we need to manually locate and reconfigure the init.d script.


-- 
To view, visit http://gerrit.ovirt.org/16204
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I484b4f1fca0e5baab2050264716b1e0fa28c03f9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to