Liron Ar has posted comments on this change.

Change subject: core: restapi: add GetVmOvfConfigurationQuery
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java
Line 143:                 runQuery(VdcQueryType.GetVmOvfConfigurationBySnapshot,
Line 144:                         new IdQueryParameters(guid));
Line 145:         if (queryReturnValue.getSucceeded() && 
queryReturnValue.getReturnValue() != null) {
Line 146:             model.setInitialization(new Initialization());
Line 147:             model.getInitialization().setConfiguration(new 
Configuration());
Nop, it was added upon our discussion in the patch that this one depends on
Line 148:             
model.getInitialization().getConfiguration().setData((String)queryReturnValue.getReturnValue());
Line 149:             
model.getInitialization().getConfiguration().setType(ConfigurationType.OVF.name());
Line 150:         }
Line 151: 


Line 145:         if (queryReturnValue.getSucceeded() && 
queryReturnValue.getReturnValue() != null) {
Line 146:             model.setInitialization(new Initialization());
Line 147:             model.getInitialization().setConfiguration(new 
Configuration());
Line 148:             
model.getInitialization().getConfiguration().setData((String)queryReturnValue.getReturnValue());
Line 149:             
model.getInitialization().getConfiguration().setType(ConfigurationType.OVF.name());
It's added, take a look in the patch that this one is dependent on
Line 150:         }
Line 151: 
Line 152:         return model;
Line 153:     }


-- 
To view, visit http://gerrit.ovirt.org/16176
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46340c4461b57a4c314fb50ca9c19ac5fd08a451
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to