Doron Fediuck has posted comments on this change. Change subject: core: Add actual free memory to vds statistics ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) - Somewhere you need to explain what memAvailable is counting and what memFree counts. The commit message is a good start but missing some info. - Please verify the sql script numbering. .................................................... Commit Message Line 7: core: Add actual free memory to vds statistics Line 8: Line 9: currently, only memAvailable is exposed by vdsm to engine. But this api is a Line 10: calculated value and so it may return negative value in case ksm Line 11: is up and pages are shred among VMs. This causes wrong 'memory under s/shred/shared/ Line 12: defined threshold' logs. Line 13: Line 14: The new "memFree" returns the true free memory on the host. Line 15: i.e. 'MemFree' + 'Cached' + 'Buffers' (from meminfo) -- To view, visit http://gerrit.ovirt.org/16256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68bbee6cc3c43636c2059443d980a2ae4c639854 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
