Moti Asayag has posted comments on this change.
Change subject: core: Add vnic profiles to DB and entities
......................................................................
Patch Set 15: (1 inline comment)
....................................................
File packaging/dbscripts/upgrade/03_03_0400_add_profile_to_network_interface.sql
Line 23: SELECT fn_db_add_column('vm_interface', 'vnic_profile_id', 'UUID');
Line 24: SELECT fn_db_add_column('vm_interface', 'vnic_profile_name',
'VARCHAR(50) NOT NULL DEFAULT ''''');
Line 25:
Line 26: ALTER TABLE vm_interface ADD CONSTRAINT
FK_vm_interface_vnic_profile_id FOREIGN KEY(vnic_profile_id)
Line 27: REFERENCES vnic_profiles(id);
I'd suggest also adding index on vm_interface (vnic_profile_id) as accessing
the VM in context of profile will be done via this field.
Eli, what do you think ?
Line 28:
Line 29: Create or replace FUNCTION
__temp_has_port_mirroring_vm_interfaces(v_network_id UUID) RETURNS BOOLEAN
Line 30: AS $procedure$
Line 31: BEGIN
--
To view, visit http://gerrit.ovirt.org/15992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
