Daniel Erez has posted comments on this change.
Change subject: userportal : Fix DiskForVmGuid high CPU
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksPartialDataByVmIdQuery.java
Line 31: //
diskImage.getSnapshots().addAll(getAllImageSnapshots(diskImage));
Line 32: // }
Line 33: // }
Line 34: // getQueryReturnValue().setReturnValue(disks);
Line 35: getQueryReturnValue().setReturnValue(allDisks);
plugged status is required for the user portal as well
Line 36: }
Line 37:
Line 38: protected List<DiskImage> getAllImageSnapshots(DiskImage
diskImage) {
Line 39: return
ImagesHandler.getAllImageSnapshots(diskImage.getImageId(),
diskImage.getImageTemplateId());
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBasicView.java
Line 6: import org.ovirt.engine.core.common.validation.group.CreateEntity;
Line 7: import org.ovirt.engine.core.common.validation.group.UpdateEntity;
Line 8: import org.ovirt.engine.core.compat.Guid;
Line 9:
Line 10: public class DiskImageBasicView extends DiskImage {
why do we need a new b.e.? we should keep using the current entity with partial
data when required...
Line 11: private static final long serialVersionUID = -1662959000228929684L;
Line 12:
Line 13: public DiskImageBasicView() {
Line 14: super();
--
To view, visit http://gerrit.ovirt.org/16657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
