Alon Bar-Lev has posted comments on this change.
Change subject: packagine: setup: Keep md5 sums of entire conf files
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 45: md5 = hashlib.new('md5')
Line 46: # Read first 100MB of file, as to not fill up memory in
Line 47: # extreme cases.
Line 48: with open(filename, 'rb') as f:
Line 49: md5.update(f.read(100000000))
this is way too large, please loop over entire file.
Line 50: return md5.hexdigest()
Line 51:
Line 52: def _safeDelete(self, filename):
Line 53: try:
--
To view, visit http://gerrit.ovirt.org/16681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8dfc2f23d1a395dfb35d12fce97896df057816f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
