Maor Lipchuk has posted comments on this change.

Change subject: core: revert when failing to export a template
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
Line 139:     public void setRevertDbOperationScope(ImageDbOperationScope 
revertDbOperationScope) {
Line 140:         this.revertDbOperationScope = revertDbOperationScope;
Line 141:     }
Line 142: 
Line 143:     public boolean getShouldLockImageOnRevert() {
What I meant is, that when we will do revert operation of "None", we can 
already know that the image should not be locked because no operation on the DB 
has been done.
Line 144:         return shouldLockImageOnRevert;
Line 145:     }
Line 146: 
Line 147:     public void setShouldLockImageOnRevert(boolean 
shouldLockImageOnRevert) {


-- 
To view, visit http://gerrit.ovirt.org/15781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d80c5d15f7321f67d54e7593cb2da1fd7186a25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to