Allon Mureinik has posted comments on this change.
Change subject: core: Add CDA message when domain is inactive
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 216: if
(!validate(storageDomainValidator.isDomainWithinThresholds())
Line 217: ||
!validate(storageDomainValidator.isDomainHasSpaceForRequest(getNeededDiskSize(domain.getId()))))
{
Line 218: return false;
Line 219: }
Line 220: if
(!validate(storageDomainValidator.isDomainExistAndActive())) {
Move this above the previous check - no point in checking space for an inactive
domain.
Line 221: return false;
Line 222: }
Line 223: }
Line 224: }
--
To view, visit http://gerrit.ovirt.org/16677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie443ccc36b2e7ccbf889f52e2b4c661269bc9aa5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
