Yair Zaslavsky has posted comments on this change. Change subject: db: host-deploy: Adding to vds_static table vars to persist ssh authentication fields ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Minor comment, also don't forget to re-number script if needed. .................................................... File backend/manager/modules/dal/src/test/resources/fixtures.xml Line 5241: <row> Line 5242: <value>vds</value> Line 5243: <value>sshkeyfingerprint</value> Line 5244: </row> Line 5245: <row> I know that indentiation is a bit broken here, but please try to align these like vms_cores_count is. Line 5246: <value>vds</value> Line 5247: <value>ssh_username</value> Line 5248: </row> Line 5249: <row> -- To view, visit http://gerrit.ovirt.org/16683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5aa1a2feb6cd37e3b0d95c39323828aa8a33c54e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
