Yaniv Bronhaim has posted comments on this change. Change subject: core: Fix some Error constants of Host Activation ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java Line 172: ACTION_TYPE_FAILED_IMPORTED_TEMPLATE_IS_MISSING(ErrorType.BAD_PARAMETERS), Line 173: ACTION_TYPE_FAILED_SPECIFY_DOMAIN_IS_NOT_EXPORT_DOMAIN(ErrorType.BAD_PARAMETERS), Line 174: ACTION_TYPE_FAILED_DETECTED_ACTIVE_VMS(ErrorType.CONFLICT), Line 175: ACTION_TYPE_FAILED_VDS_WITH_SAME_HOST_EXIST(ErrorType.CONFLICT), Line 176: ACTION_TYPE_FAILED_VDS_WITH_SAME_UUID_EXIST(ErrorType.CONFLICT), I suggest to put it near those 2, SAME_UUID, SAME_HOST .. all Vds action errors. and if you don't put ACTION_TYPE_FAILED before the verbs you are changing, remove it also for those 2 Line 177: ACTION_TYPE_FAILED_ILLEGAL_MEMORY_SIZE(ErrorType.CONSTRAINT_VIOLATION), Line 178: ACTION_TYPE_FAILED_ILLEGAL_NUM_OF_MONITORS(ErrorType.BAD_PARAMETERS), Line 179: ACTION_TYPE_FAILED_ILLEGAL_DOMAIN_NAME(ErrorType.BAD_PARAMETERS), Line 180: ACTION_TYPE_FAILED_MAX_NUM_CPU(ErrorType.CONFLICT), -- To view, visit http://gerrit.ovirt.org/16648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65d5cd35c8ef4a1a318670a90ffdfb9bfce9ad8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
